fix(math): add missing changes from #388 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
ashjeong
reviewed
Apr 17, 2024
Yes, since this is not used anywhere, so I didn't notice that! Thanks :) |
chokobole
force-pushed
the
fix/fix-compile-error-with-cuda
branch
from
bf163fc
to
c106c41
Compare
|
I just thought of it, maybe we should've added test cases for #388 where |
1. Removes temporary debugging code. 2. Ensures that this code, designed to mimic `PrimeFieldGpu` on the CPU side, runs identically to its counterpart.
chokobole
force-pushed
the
fix/fix-compile-error-with-cuda
branch
from
c106c41
to
59506c4
Compare
I added it! |
I changed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the compilation error that occurred in #388.