feat: add packed mersenne31 #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
feat/add-packed-mersenne31
branch
4 times, most recently
from
2cd68e4
to
fa8c9b6
Compare
chokobole
force-pushed
the
feat/add-packed-mersenne31
branch
8 times, most recently
from
e67f22f
to
11c2b6b
Compare
ashjeong
reviewed
Apr 24, 2024
chokobole
force-pushed
the
feat/add-packed-mersenne31
branch
2 times, most recently
from
c4b4c7b
to
11c2b6b
Compare
Aditionally, the function now accepts not only vector types but also any container type for increased flexibility.
chokobole
force-pushed
the
feat/add-packed-mersenne31
branch
from
11c2b6b
to
dbdbf3b
Compare
Insun35
changed the title
Insun35
reviewed
Apr 24, 2024
dongchangYoo
requested changes
Apr 24, 2024
tachyon/math/finite_fields/mersenne31/packed_mersenne31_avx512.h
Outdated
Show resolved
Hide resolved
chokobole
force-pushed
the
feat/add-packed-mersenne31
branch
2 times, most recently
from
b91dccc
to
13338bf
Compare
See https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/mersenne-31/src/x86_64_avx2/packing.rs, https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/mersenne-31/src/x86_64_avx512/packing.rs and https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/mersenne-31/src/aarch64_neon/packing.rs.
Since #387, `Mersenne31` is instantiated with `small_prime_field_generic.h` and all the mathematical methods become constexpr.
chokobole
force-pushed
the
feat/add-packed-mersenne31
branch
from
13338bf
to
47e6217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds PackedPrimeField for
Mersenne31.