Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point Juno missions #58

Merged
merged 23 commits into from Sep 18, 2017
Merged

Point Juno missions #58

merged 23 commits into from Sep 18, 2017

Conversation

gcabbage
Copy link
Contributor

@gcabbage gcabbage commented Aug 27, 2017

These still need a bit more polish especially if the player declines the mission or docks after the initial attack has stated, but they're ready for review. In particular I'd like feedback on the following:

  • stCSCEuropaWreck I think this should not be part of PointJuno.xml so the system can be used without the wreck (e.g. for adventures set before/after the SotP time). The wreck itself should be placed by a OnGlobalSystemStarted/Created event in the mission. CommonwealthFleetMissionLL03 is probably the best place for it but need to consider that a future Blackmarket/outlaw/??? mission chain could involve the player stealing the prototype for another faction left in PointJuno
  • stCenturionWreck, stSandstormWreck these should be moved to an encounter module - EncountersVol01.xml or a new StdShipwrecks.xml? Moved to EncountersVol01

Ministry links:

@gcabbage gcabbage mentioned this pull request Aug 27, 2017
@gcabbage
Copy link
Contributor Author

I've added the first part of the Antarctica mission:

  • rpgCharacter for Captain Helios
  • Dantalion Informant implemented as MissionType
  • Antarctica escape / attack by Aquilas as MissionType
  • stDantalionSettlement and stCSCAntarcticaEncounter are now obsolete
  • The CSC Terra & Decker have not been converted yet

I made two modifications to dsRPGMission (also see: Blocking missions)

  • ReplyDecline text is now optional
  • Unavailable text is shown with rpgPagePaneInit

The Antarctica Escape mission:

  • will run as a normal player mission if they opt to help Helios, and a non-player (msnSetUnavailable) if they do not.
  • uses rpgMissionAssignmentOnScreenInit and a GetDockScreen event to try and stay as close as possible to original behavior. Alternatively it could be done with a rpgCharacterMission, but then the Antarctica dockservices would never be available)
  • still needs minor updates to match original behavior dependent on fleet rank when refusing to help Helios.

@NMS127
Copy link
Contributor

NMS127 commented Sep 12, 2017

As part of merging PM's HD renders into core, I had to make changes to CommonwealthFleet.xml and HumanSpaceVol01.xml, so one of us may have to manually deconflict these. But I don't think it should be too hard.

@gcabbage
Copy link
Contributor Author

The CommonwealthFleet changes should be fine as we've both made only minor edits to completely different parts of the file.

@gmoromisato
Copy link
Member

I think is OK to leave the CSC Europa wreck in PointJuno.xml, mostly because other missions might use it (like the Black Market mission you hinted at). To handle other time period I think we'll need to create new system definitions/libraries. Otherwise we would have to remove everything (what about a time before/after the Point Juno stronghold)?

I agree that the wreck definitions should be moved. EncountersVol01.xml is good (at some point that file should get renamed to MiscEncounters.xml or something).

@gcabbage
Copy link
Contributor Author

gcabbage commented Sep 15, 2017

Antarctica and Terra missions are now implemented. There are probably still a few bugs, but it should be good enough for alpha (and testing will help find the bugs!).

  • The lamplighter is offered via price reduction (similar to ED/APD reward weapons)
  • I've merged the CSC ANTARCTICA unid range with a new COMMONWEALTH FLEET II one, but they could be separated again if you think there might be more Antarctica missions in the future.
  • CSC Terra is currently in a separate file, it could be moved into CommonwealthFeet, or we could add a rpgCharacter for Decker in the future

@gmoromisato gmoromisato merged commit 3f4bd7d into kronosaur:master Sep 18, 2017
@gmoromisato
Copy link
Member

Thank you!

@gcabbage gcabbage deleted the pointJuno branch September 23, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants