Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. fixes #93

Merged
merged 12 commits into from Jul 27, 2018
Merged

Misc. fixes #93

merged 12 commits into from Jul 27, 2018

Conversation

NMS127
Copy link
Contributor

@NMS127 NMS127 commented Jun 22, 2018

No description provided.

NMS127 added 12 commits June 22, 2018 02:14
@NMS127
Ice farms shouldn't buy luxury foods since they sell them at lower pr…
520e9b5 
…ices

https://ministry.kronosaur.com/record.hexm?id=79945
@NMS127
Action ID for dsRPGRepairItem
7a344f9 
https://ministry.kronosaur.com/record.hexm?id=79955
@NMS127
Actions in screens created by rpgPagePaneInit default to exiting the …
13d3d85 
…screen if the next page has an ID

Removed unnecessary IDs in one mission so this won't break it. I don't think anything else will break, but if it does, we can fix it by specifying the ID of the next page.

https://ministry.kronosaur.com/record.hexm?id=79732
@NMS127
Different message if wingman is ordered to attack nothing
ffc30ca 
This can happen if the target is destroyed between opening the comms menu and issuing the order. Previously, this would trigger the "I can't attack friends" message.

Also, set behavior data before changing orders in case we need it in an OnOrdersChanged event at some point.
@NMS127
Prevent and debug disappearing wingmen
6cc5eef 
Also reduce code duplication and use objSendMessageTranslate.

https://ministry.kronosaur.com/record.hexm?id=79976
@NMS127
If nextPage is explicitly 'nextPage, continue even if next page has ID
49bdc6d
@NMS127
Default to exiting when next page has ID only for actions in a list, …
1992321 
…not auto-generated action
@NMS127
Map ROM "improvements"
025c93f 
https://ministry.kronosaur.com/record.hexm?id=80128
@NMS127
Make slave quarters use small LRS icons
d366517
@NMS127
Fix "credits credits" in mission briefing
b9df2b2 
https://ministry.kronosaur.com/record.hexm?id=80190
@NMS127
Fix missing text in Juan Carlos mission
3af0945 
https://ministry.kronosaur.com/record.hexm?id=80411
@NMS127
AcceptDonation criteria
bdd851d 
In case anything actually checks this.
@INeedAUniqueUsername
Copy link
Contributor

INeedAUniqueUsername commented Jul 27, 2018 •
edited

That commit bdd851d prevents the player from donating the Dall Sphere to the Sisters of Domina (which would show a special donation text and softlock the Dall Mission at the same time).

Discuss here: http://ministry.kronosaur.com/record.hexm?id=80508

<ItemType UNID="&itDallSphere;"
		name=				"inert metal sphere"
		level=				"10"
		value=				"0"
		mass=				"1000"
		frequency=			"notRandom"
		attributes=			"alien, notForSale, questItem"

		description=		"This is a one-meter sphere of a dark metal, etched with a network of thin lines and complex shapes."
		>

	<Image imageID="&rsDallSphere;" imageX="0" imageY="0" imageWidth="96" imageHeight="96"/>
	
	<StaticData>
		<Data id="sisters.donation">
			;		attd	rel		text
			'(Nil	-1		200		"This is a remarkable item! Domina will be very pleased!")
		</Data>

@gmoromisato gmoromisato merged commit 755f9a0 into kronosaur:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NMS127 @INeedAUniqueUsername @gmoromisato