Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't start storybook in docs mode by default #495

Merged
merged 2 commits into from
May 5, 2023

Conversation

pylafleur
Copy link
Contributor

Le mode documentation ne présente qu'un aperçu des pages de docs, et les stories n'apparaissent pas dans le menu latéral. Ça porte un peu à confusion vu que le rendu est différent de la version complète qui est générée avec yarn build.

Je propose de générer la version standard par défaut, tout en laissant l'option --docs dans une commande à part. Le temps de compilation est essentiellement pareil pour les deux modes.

https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation

@pylafleur pylafleur requested a review from a team as a code owner May 5, 2023 14:09
meriouma
meriouma previously approved these changes May 5, 2023
@pylafleur pylafleur merged commit 2b48141 into master May 5, 2023
@pylafleur pylafleur deleted the dev/storybook-start branch May 5, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants