Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expected response code is always code + 1 #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kingrollsdice
Copy link

@kingrollsdice kingrollsdice commented May 12, 2021

As per the protocol, expected response code is always code + 1

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

As per the protocol, expected response code  is always code + 1
@kroo
Copy link
Owner

kroo commented May 12, 2021

It's interesting; this does seem to be the case by convention -- but I haven't decoded too many of the commands you can send to the camera yet. I wonder if there are any scenarios where the response is not code + 1...

@@ -65,11 +65,9 @@ class TutkWyzeProtocolMessage:
:var expected_response_code: the code of the message expected to
be the 'response' to this one, from
the camera.
:vartype expected_response_code: int
:vartype expected_response_code: int is always code + 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be part of the :var: docstring comment, not :vartype:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants