Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream error handling #269

Closed
djungelorm opened this issue May 8, 2016 · 1 comment
Closed

Stream error handling #269

djungelorm opened this issue May 8, 2016 · 1 comment
Labels
client:cpp client:csharp client:java client:python enhancement New feature or request server:api
Milestone
0.4.0

Comments

@djungelorm
Copy link
Member

Need better handling of errors in streamed RPCs. At the moment, clients differ in how they handle this. E.g. C# ignores the error, Python passes the error to the client when __call__() is invoked but leaves the stream open.

Possible desired behaviour:

  • Server sends a response with the error field set, then closes the stream.
  • Clients set the streams value such that calling get throws the RPC error exception
@djungelorm djungelorm added this to the 0.4.0 milestone Jun 25, 2016
@djungelorm
Copy link
Member Author

Not applicable to Lua client (doesn't support streams)

djungelorm added a commit that referenced this issue Jul 11, 2017
@djungelorm
Merge branch 'v0.4.0-feature/stream-improvements' into v0.4.0 (Fix #269)
9c5374f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client:cpp client:csharp client:java client:python enhancement New feature or request server:api
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@djungelorm