Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the About Us page #32

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Added the About Us page #32

merged 1 commit into from
Dec 16, 2019

Conversation

Suchana34
Copy link
Contributor

@Suchana34 Suchana34 commented Dec 15, 2019 •
edited
Loading

Pull request checklist

Checklist:

  • I have performed a self-review of my own code
  • I have deployed locally to see if issue is fixed
  • I have commented my code, particularly in hard-to-understand areas
  • Assigned current issues or new issues to PR

@Suchana34
Copy link
Contributor Author

Added and designed the About Us page.

@Suchana34
Copy link
Contributor Author

I have designed the details of the guesthouses by the Flip- Card CSS template.

@krritik
Copy link
Owner

krritik commented Dec 15, 2019

A screenshot of the about page will be useful

@Suchana34
Copy link
Contributor Author

Screenshot (287)

@Suchana34
Copy link
Contributor Author

Screenshot (288)

@Suchana34
Copy link
Contributor Author

Screenshot (289)

@Suchana34
Copy link
Contributor Author

Screenshot (290)

@Suchana34
Copy link
Contributor Author

Screenshot (291)

@Suchana34
Copy link
Contributor Author

I have actually made the about us page based on the frontend design existing currently. As the frontend updates, I will update the page accordingly.

@krritik
Copy link
Owner

krritik commented Dec 16, 2019 •
edited
Loading

@Suchana34
NOTE: Never send a PR from the master branch, because your master branch will be overwritten while resolving the commit. So you will get different commit history

@krritik
Copy link
Owner

krritik commented Dec 16, 2019

I will merge it now but do remember from next time while sending PR

@krritik krritik merged commit bc67e1e into krritik:master Dec 16, 2019
@krritik krritik mentioned this pull request Dec 16, 2019
Closed
@Suchana34
Copy link
Contributor Author

Thank you for the advice. I will surely look after it from next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suchana34 @krritik