Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Adding or removing shapes from notes not being received by clients until a refresh #1410

Closed
rexy712 opened this issue Feb 24, 2024 · 1 comment

Comments

@rexy712
Copy link
Contributor

rexy712 commented Feb 24, 2024

Describe the bug
When adding a shape to a note, your client sees the update happen immediately. Other clients do not see the change until they refresh the page or until view access for the note is removed and granted again.

The event is being sent to the server, but it seems like the other clients never receive the update from the server.

To Reproduce
Steps to reproduce the behavior:

  1. Create a shape.
  2. Create a note, give default view access. They can see the note in the notes manager.
  3. In the note manager, select 'shapes' submenu for the note.
  4. Add the shape from step 1 to the note. Selecting the shape as this player shows 1 note in the Selection View.
  5. As second player: Select the shape. In the Selection View, it still says 0 notes.
  6. As second player: Refresh the page, reselect shape. Selection View now says 1 note.

Expected behavior
The status of the notes should update immediately.

Screenshots

This video shows that the icons are not updated, but it is also evident when selecting the shape. This is not an icon bug, but rather the client is not receiving the shape add event.

note-add-rem-not-recv-bug.mp4

Desktop:

  • OS: gentoo linux
  • Browser: ungoogled-chromium 121.0.6167.160, firefox 122.0.1
  • Version: dev branch commit a44fd4d
@Kruptein
Copy link
Owner

Fixed in #1413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants