Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Undoing shape removal does not reattach shape to notes #1416

Open
rexy712 opened this issue Feb 27, 2024 · 1 comment
Open

[BUG] Undoing shape removal does not reattach shape to notes #1416

rexy712 opened this issue Feb 27, 2024 · 1 comment

Comments

@rexy712
Copy link
Contributor

rexy712 commented Feb 27, 2024

Describe the bug
When deleting a shape, any notes the shape was attached to lose that attachment. Performing an undo action should reattach them presumably, but it does not. The client never sees the shape removed from the note's list of attached shapes, so it appears to reattach until refreshed. The server, however, sees the attached shape removed from the note when the shape was deleted.

To Reproduce
Steps to reproduce the behavior:

  1. Create a shape, attach note to it.
  2. Delete the shape.
  3. Ctrl+Z to undo the deletion.
  4. The note appears to reattach on the client until a refresh.
  5. After refresh, the shape shows it is truly not attached to the note.

Expected behavior
Notes reattach shapes when undoing a shape removal.

Screenshots

undo-note-bug.mp4

Desktop:

  • OS: gentoo linux
  • Browser: ungoogled-chromium 121.0.6167.160, firefox 122.0.1
  • Version: dev branch commit b945737
@rexy712 rexy712 changed the title [BUG] [BUG] Undoing shape removal does not reattach shape to notes Feb 27, 2024
@Kruptein
Copy link
Owner

The UI not updating properly has been fixed.

The core of the issue however is more difficult to tackle as the information of which notes were attached to the shape are gone by the time the undo action is triggered.

This information will have to be added to the undo-stack info, but there probably is more info that is lost that should be added. (e.g. group information)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants