Remove k8s-openapi version feature from kubelet #691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #612
I think this is all we need,
kubelet
andwasi-provider
crates now only specify the version feature in dev-dependencies.Our binaries are compiled with the specific version we test (1.22 right now).
I verified that I can create new project which imports
kubelet
crate, and specify a different version without issues.The only missing component is that we discussed specifying a default version, and requiring the user to turn off default features to customize their API version.
k8s-openapi
is pretty explicit that libraries should not specify version features. Would it be worth reaching out to the author to get their opinion? @bacongobbler