add ability to resize packer #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryptan
reviewed
Sep 18, 2017
src/packer/packer.rs
Outdated
| // The new skyline starts where the furthest one ends | ||
| let mut left = 0; | ||
| for skyline in self.skylines.iter() { | ||
| left = max(left, skyline.left); |
There was a problem hiding this comment.
I don't remember how all this stuff works exactly but shouldn't it be left = max(left, skyline.right()); instead?
Also, is the loop necessary? Skylines are probably already sorted and you can just take the last one if I remember correctly.
There was a problem hiding this comment.
You are correct, I have amended those changes.
|
Thanks, didn't know someone is using this library) Have you tested your changes? |
|
I have tested with my application. There was a slight bug before, but with the changes that you requested it's gone now. I tested at font sizes 100, 150, 200, 300, 500, and 1000 and the glyph atlas seems to come out right every time. |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1