Fix linting errors

krzko · Jul 26, 2022 · 6c23376 · 6c23376
1 parent 2e83efb
commit 6c23376
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/internal/cli/cli.go b/internal/cli/cli.go
@@ -26,6 +26,9 @@ func initLogger(c *cli.Context) error {
 	logger, err = cfg.Build()
 
 	defer logger.Sync()
+	if err != nil {
+		panic(err)
+	}
 
 	return err
 }

diff --git a/internal/cli/metrics_counter_with_labels.go b/internal/cli/metrics_counter_with_labels.go
@@ -29,7 +29,6 @@ var generateMetricsCounterWithLabelsCommand = &cli.Command{
 
 func generateMetricsCounterWithLabelsAction(c *cli.Context) error {
 	var err error
-	defer logger.Sync()
 
 	if c.String("otel-exporter-otlp-endpoint") == "" {
 		return errors.New("'otel-exporter-otlp-endpoint' must be set")

diff --git a/internal/cli/traces.go b/internal/cli/traces.go
@@ -42,7 +42,6 @@ func genTracesCommand() *cli.Command {
 				},
 				Action: func(c *cli.Context) error {
 					var err error
-					defer logger.Sync()
 
 					if c.String("otel-exporter-otlp-endpoint") == "" {
 						return errors.New("'otel-exporter-otlp-endpoint' must be set")

diff --git a/internal/metrics/config.go b/internal/metrics/config.go
@@ -53,7 +53,7 @@ func (v *HeaderValue) Set(s string) error {
 func Run(ctx context.Context, exp *otlpmetric.Exporter, m metric.Meter, c *Config, logger *zap.Logger) (func(), error) {
 	limit := rate.Limit(c.Rate)
 	if c.Rate == 0 {
-		limit = rate.Inf
+		limit = rate.Inf //nolint
 		logger.Info("generation of metrics isn't being throttled")
 	} else {
 		logger.Info("generation of metrics is limited", zap.Float64("per-second", float64(limit)))