Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for SwiftPM #58

Merged
merged 10 commits into from
Dec 21, 2016
Merged

Adding Support for SwiftPM #58

merged 10 commits into from
Dec 21, 2016

Conversation

vknabel
Copy link
Contributor

@vknabel vknabel commented Dec 19, 2016

This PR adds support for macOS-only SwiftPM support.
Currently building is only supported by running xcrun -sdk macosx swift build.
This implementation currently uses some forks instead of the real projects in order to add (currently) missing version tags.

Currently missing:

  • Support for swift build
  • README.md updates
  • CircleCI and TravisCI updates
  • Support for swift test

@krzysztofzablocki
Copy link
Owner

krzysztofzablocki commented Dec 20, 2016

thanks for contributing!
What do you think would be the best approach to follow up on those checkbox items?

btw. swift build works for me on Xcode 8.2

@vknabel
Copy link
Contributor Author

vknabel commented Dec 20, 2016

I will open some follow up PRs. This way others can start to experiment with Homebrew support.

Did you use Xcode's Swift? Mine has been installed with swiftenv.

@vknabel
Copy link
Contributor Author

vknabel commented Dec 20, 2016

@krzysztofzablocki Adding support for swift test would take a bit more time as there are multiple compile errors for the test targets. Shall we merge this PR? I would open another PR later.

Once it's merge-time: in the CHANGELOG.md I used Future Release as a placeholder. Before you merge it I may change it to the next version.

@krzysztofzablocki
Copy link
Owner

Sounds good to me, you can just put # Master as release version, we gather changes that are in master and then when I do next release I change it to future version :)

Any chance we could change the product name in SPM version to be lowercase sourcery rather than uppercase?

@krzysztofzablocki
Copy link
Owner

We should update the readme entry to lowercase as well, thank you so much for your help with this :)

@krzysztofzablocki krzysztofzablocki merged commit 554d9a4 into krzysztofzablocki:master Dec 21, 2016
@krzysztofzablocki
Copy link
Owner

krzysztofzablocki commented Dec 21, 2016

@vknabel I think I pressed the merge too fast instead of waiting on CI, any idea why error: these referenced modules could not be found: sourcery would happen ?

@vknabel
Copy link
Contributor Author

vknabel commented Dec 21, 2016

@krzysztofzablocki Git has sometimes problems when renaming files from Uppercase to Lowercase. Opened #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants