Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to add new ModelMesh committers #6

Closed
ckadner opened this issue Sep 18, 2023 · 5 comments · Fixed by kserve/modelmesh#109, kserve/modelmesh-runtime-adapter#56 or kserve/modelmesh-serving#437
Assignees

Comments

@ckadner
Copy link
Member

ckadner commented Sep 18, 2023

We recently codified the process of how outstanding KServe contributors can be promoted to become committers.

This issue starts the process of a first selection of candidates. The output of the list-contributors.py script is used as a reference point to help with selecting candidates.

  1. Top PR authors
  2. Top PR reviewers
  3. Top contributors (PRs authored and/or reviewed)

The contribution activity spans the previous 6 months. Current committers and bot accounts are excluded.

Actual candidates to be promoted will be nominated by current committers and (in this first round of promotions) can be voted on by all contributors.

1. Top PR authors:

$ ./scripts/python/list-contributors.py --repo kserve/modelmesh-serving -n 3 -r author

Contributors to 'kserve/modelmesh-serving' (PR authors) by number of PRs (>3) since 2023-03-22:

 17  rafvasq            [422, 421, 417, 416, 413, 412, 406, 405, 403, 391, 390, 379, ... ]
  7  ckadner            [429, 415, 414, 404, 371, 368, 354]

2. Top PR reviewers:

$ ./scripts/python/list-contributors.py --repo kserve/modelmesh-serving  -n 3 -r reviewer commenter

Contributors to 'kserve/modelmesh-serving' (PR commenters, reviewers) by number of PRs (>3) since 2023-03-22:

 25  ckadner            [428, 425, 422, 421, 417, 416, 413, 412, 406, 405, 403, 400, ... ]
  9  rafvasq            [429, 428, 415, 414, 404, 398, 395, 394, 375]

3. Top contributors (PRs authored and/or reviewed):

$ ./scripts/python/list-contributors.py --repo kserve/modelmesh-serving -n 3

Contributors to 'kserve/modelmesh-serving' (PR authors, commenters, reviewers) by number of PRs (>3) since 2023-03-22:

 32  ckadner            [429, 428, 425, 422, 421, 417, 416, 415, 414, 413, 412, 406, ... ]
 26  rafvasq            [429, 428, 422, 421, 417, 416, 415, 414, 413, 412, 406, 405, ... ]
  3  Jooho              [400, 397, 363]

@njhill

@ckadner
Copy link
Member Author

ckadner commented Sep 18, 2023

FYI @rafvasq

@ckadner
Copy link
Member Author

ckadner commented Sep 19, 2023

This could look like I am shamelessly self-promoting here, but, Rafael and Jooho are here too. So it's totally legit!

😎

@njhill
Copy link
Member

njhill commented Sep 28, 2023

I approve!

@ckadner
Copy link
Member Author

ckadner commented Sep 28, 2023

ckadner added a commit to kserve/modelmesh that referenced this issue Sep 28, 2023
Add new approvers to OWNERS file following KServe community process.

Closes kserve/community#6

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ckadner added a commit to kserve/modelmesh-runtime-adapter that referenced this issue Sep 28, 2023
Add new approvers to OWNERS file following KServe community process.

Closes kserve/community#6

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ckadner added a commit to kserve/modelmesh-serving that referenced this issue Sep 28, 2023
Add new approvers to OWNERS file following KServe community process.

Closes kserve/community#6

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ckadner added a commit to kserve/modelmesh-runtime-adapter that referenced this issue Sep 28, 2023
Add new approvers to OWNERS file following KServe community process.

Closes kserve/community#6

---

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ckadner added a commit to kserve/modelmesh-serving that referenced this issue Sep 28, 2023
Add new approvers to OWNERS file following KServe community process.

Closes kserve/community#6

/approved by @njhill

---

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ckadner added a commit to kserve/modelmesh that referenced this issue Sep 28, 2023
Add new approvers to OWNERS file following KServe community process.

Closes kserve/community#6

Approved by @njhill

---

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Copy link
Member Author

ckadner commented Sep 28, 2023

Thanks @njhill

GolanLevy pushed a commit to GolanLevy/modelmesh-runtime-adapter that referenced this issue Oct 1, 2023
Add new approvers to OWNERS file following KServe community process.

Closes kserve/community#6

---

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Golan Levy <golan.levy@gong.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment