Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kserve python dep #2103

Merged

Conversation

Suresh-Nakkeran
Copy link
Contributor

@Suresh-Nakkeran Suresh-Nakkeran commented Mar 18, 2022

This PR is to upgrade KServe Python SDk dependencies.

fixes #2041

@Suresh-Nakkeran
Copy link
Contributor Author

/retest

1 similar comment
@Suresh-Nakkeran
Copy link
Contributor Author

/retest

ray[serve]==1.9.2
grpcio>=1.34.0
google_api_core==1.29.0
google_api_core==2.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove pinned google_api_core as it is depended by google-cloud-storage.
https://github.com/googleapis/python-storage/blob/main/setup.py#L32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

tritonclient==2.14.2
googleapis_common_protos==1.54.0
cachetools==5.0.0
google_auth==2.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove pinned google_auth as it is depended by google-cloud-storage.
https://github.com/googleapis/python-storage/blob/main/setup.py#L31

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

cachetools==5.0.0
google_auth==2.6.0
cffi==1.15.0
cryptography==36.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove pinned cryptography as it is depended by azure-storage-blob
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/setup.py#L81

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

cryptography==36.0.1
idna==3.3
certifi==2021.10.8
azure_core==1.23.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove pinned azure_core as it is depended by azure-storage-blob
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/setup.py#L79

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
@yuzisun
Copy link
Member

yuzisun commented Mar 21, 2022

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Suresh-Nakkeran, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit e7dfa0a into kserve:master Mar 21, 2022
yuzisun pushed a commit to yuzisun/kserve that referenced this pull request Apr 23, 2022
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
yuzisun pushed a commit to yuzisun/kserve that referenced this pull request Apr 23, 2022
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
kserve-oss-bot pushed a commit that referenced this pull request Apr 29, 2022
* Remove pinned google_api_core

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Publish a minor patch

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@ddelange ddelange mentioned this pull request Jun 8, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install required version of numpy on M1 mac
3 participants