-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kserve python dep #2103
Upgrade kserve python dep #2103
Conversation
d0a7aef
to
613e7c8
Compare
/retest |
1 similar comment
/retest |
python/kserve/requirements.txt
Outdated
ray[serve]==1.9.2 | ||
grpcio>=1.34.0 | ||
google_api_core==1.29.0 | ||
google_api_core==2.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove pinned google_api_core
as it is depended by google-cloud-storage
.
https://github.com/googleapis/python-storage/blob/main/setup.py#L32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
python/kserve/requirements.txt
Outdated
tritonclient==2.14.2 | ||
googleapis_common_protos==1.54.0 | ||
cachetools==5.0.0 | ||
google_auth==2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove pinned google_auth
as it is depended by google-cloud-storage
.
https://github.com/googleapis/python-storage/blob/main/setup.py#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
python/kserve/requirements.txt
Outdated
cachetools==5.0.0 | ||
google_auth==2.6.0 | ||
cffi==1.15.0 | ||
cryptography==36.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove pinned cryptography
as it is depended by azure-storage-blob
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/setup.py#L81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
python/kserve/requirements.txt
Outdated
cryptography==36.0.1 | ||
idna==3.3 | ||
certifi==2021.10.8 | ||
azure_core==1.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove pinned azure_core
as it is depended by azure-storage-blob
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/setup.py#L79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
c4d0250
to
e0b3341
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Suresh-Nakkeran, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net>
This PR is to upgrade KServe Python SDk dependencies.
fixes #2041