Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen setuptools lower pin #2231

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Loosen setuptools lower pin #2231

merged 1 commit into from
Jul 21, 2022

Conversation

ddelange
Copy link
Contributor

@ddelange ddelange commented Jun 8, 2022

What this PR does / why we need it:

This PR fixes compatibility with torch==1.10.* (which implicitly depends on setuptools<=59.5.0 ref autogluon/autogluon#1786 (comment)) and so allows serving custom models trained using those torch versions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:

Fix compatibility of the python package with torch==1.10.*

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
@ddelange
Copy link
Contributor Author

ddelange commented Jun 8, 2022

cc @Suresh-Nakkeran as you raised the lower pin in #2103

@ddelange
Copy link
Contributor Author

ddelange commented Jun 8, 2022

@yuzisun all green, do you think this PR can still be included in v0.9.0-rc0?

@ddelange
Copy link
Contributor Author

ddelange commented Jul 4, 2022

@pvaneck taking the liberty to ping you ^^

Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
However, I am wondering if setuptools even needs to be specified in the requirements.txt file. Should be included with the Python distribution like pip is, right?

@ddelange
Copy link
Contributor Author

ddelange commented Jul 6, 2022

not all distributions include it. conda does, pyenv does, homebrew does. but e.g. apt-get doesnt: making a venv from here will require the user to install setuptools separately

@ddelange
Copy link
Contributor Author

@pvaneck anything from my side still?

@yuzisun
Copy link
Member

yuzisun commented Jul 21, 2022

/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddelange, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 318082d into kserve:master Jul 21, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants