-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen setuptools lower pin #2231
Conversation
Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
cc @Suresh-Nakkeran as you raised the lower pin in #2103 |
@yuzisun all green, do you think this PR can still be included in v0.9.0-rc0? |
@pvaneck taking the liberty to ping you ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
However, I am wondering if setuptools
even needs to be specified in the requirements.txt
file. Should be included with the Python distribution like pip
is, right?
not all distributions include it. conda does, pyenv does, homebrew does. but e.g. apt-get doesnt: making a venv from here will require the user to install setuptools separately |
@pvaneck anything from my side still? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddelange, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Signed-off-by: alexagriffith <agriffith96@gmail.com>
What this PR does / why we need it:
This PR fixes compatibility with
torch==1.10.*
(which implicitly depends onsetuptools<=59.5.0
ref autogluon/autogluon#1786 (comment)) and so allows serving custom models trained using those torch versions.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: