Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: adds huggingface bloom example to torchserve #2466

Merged
merged 6 commits into from
Mar 4, 2023
Merged

Feat: adds huggingface bloom example to torchserve #2466

merged 6 commits into from
Mar 4, 2023

Conversation

jagadeeshi2i
Copy link
Member

@jagadeeshi2i jagadeeshi2i commented Oct 10, 2022 •
edited by yuzisun

What this PR does / why we need it:

Adds Huggingface bloom example to Torchserve

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:

@jagadeeshi2i
Feat: add huggingface bloom example to torchserve
b2e9c2d 
Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
@jagadeeshi2i
fix: add pv and helper pod yaml
6dd5fc3 
 - update readme doc
 - add storageclass yaml
 - fix config.properties

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
@jagadeeshi2i jagadeeshi2i changed the title [WIP] Feat: adds huggingface bloom example to torchserve Feat: adds huggingface bloom example to torchserve Nov 18, 2022
@jagadeeshi2i
fix: add steps for model sharding
17aefe0 
 - fix doc

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
@jagadeeshi2i
fix: readme docs
e863d5a 
Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
@jagadeeshi2i
fix: readme doc
1444d67 
Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
@jagadeeshi2i
fix: readme docs
aa34839 
Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
@yuzisun
Copy link
Member

yuzisun commented Mar 4, 2023

Thanks @jagadeeshi2i !

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chauhang, jagadeeshi2i, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 38465ea into kserve:master Mar 4, 2023
yuzisun pushed a commit to yuzisun/kserve that referenced this pull request Mar 5, 2023
@jagadeeshi2i @yuzisun
Feat: adds huggingface bloom example to torchserve (kserve#2466)
68e0523 
* Feat: add huggingface bloom example to torchserve

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* fix: add pv and helper pod yaml

 - update readme doc
 - add storageclass yaml
 - fix config.properties

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* fix: add steps for model sharding
sriumcp pushed a commit to sriumcp/kserve that referenced this pull request Mar 7, 2023
@jagadeeshi2i @sriumcp
Feat: adds huggingface bloom example to torchserve (kserve#2466)
ad42942 
* Feat: add huggingface bloom example to torchserve

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* fix: add pv and helper pod yaml

 - update readme doc
 - add storageclass yaml
 - fix config.properties

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* fix: add steps for model sharding

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
ddelange added a commit to ddelange/kserve that referenced this pull request Apr 3, 2023
@ddelange
Merge branch 'master' of https://github.com/kserve/kserve into config…
f9463e3 
…urable-scheduling

* 'master' of https://github.com/kserve/kserve: (49 commits)
  Implement v2/open inference endpoints for OOTB python model servers (kserve#2655)
  Parametrized docker build (kserve#2666)
  Fix formatting and controller tests (kserve#2783)
  support multiple containers in ServingRuntime (kserve#2321)
  model_server.py: fix documentation for enable_latency_logging (kserve#2777)
  Updating Knative Serving and Istio to their latest version (kserve#2697)
  Support Direct VolumeMount for PVC (kserve#2738)
  fix missing ingress config options in helm chart (kserve#2772)
  fix trained model ready status (kserve#2774)
  Fix running out of disk space in e2e (kserve#2765)
  Iter8 canary and performance testing samples (kserve#2752)
  adjust order of types to default to float,int (kserve#2754)
  Make storage dependency as an optional dependency (kserve#2700)
  Creating new manifests for v0.10.1 (kserve#2736) (kserve#2739)
  Upgrdaing cherry pick action to v1.0.9 (kserve#2735)
  Feat: adds huggingface bloom example to torchserve (kserve#2466)
  Adding podaffinity and resourcerequirments to IG Spec (kserve#2711)
  Update OWNERS (kserve#2724)
  Fix knative installation failure in e2e test (kserve#2726)
  Use fork in multiprocessing mode (kserve#2718)
  ...
Iamlovingit pushed a commit to Iamlovingit/kserve that referenced this pull request Oct 1, 2023
@jagadeeshi2i @Iamlovingit
Feat: adds huggingface bloom example to torchserve (kserve#2466)
f83dfc7 
* Feat: add huggingface bloom example to torchserve

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* fix: add pv and helper pod yaml

 - update readme doc
 - add storageclass yaml
 - fix config.properties

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* fix: add steps for model sharding

Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzisun yuzisun yuzisun left review comments

@chauhang chauhang chauhang approved these changes

@Iamlovingit Iamlovingit Awaiting requested review from Iamlovingit

@theofpa theofpa Awaiting requested review from theofpa

Assignees

@yuzisun yuzisun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jagadeeshi2i @yuzisun @kserve-oss-bot @chauhang