Fix formatting and controller tests #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ddelange
added a commit
to ddelange/kserve
that referenced
this pull request
Apr 3, 2023
…urable-scheduling * 'master' of https://github.com/kserve/kserve: (49 commits) Implement v2/open inference endpoints for OOTB python model servers (kserve#2655) Parametrized docker build (kserve#2666) Fix formatting and controller tests (kserve#2783) support multiple containers in ServingRuntime (kserve#2321) model_server.py: fix documentation for enable_latency_logging (kserve#2777) Updating Knative Serving and Istio to their latest version (kserve#2697) Support Direct VolumeMount for PVC (kserve#2738) fix missing ingress config options in helm chart (kserve#2772) fix trained model ready status (kserve#2774) Fix running out of disk space in e2e (kserve#2765) Iter8 canary and performance testing samples (kserve#2752) adjust order of types to default to float,int (kserve#2754) Make storage dependency as an optional dependency (kserve#2700) Creating new manifests for v0.10.1 (kserve#2736) (kserve#2739) Upgrdaing cherry pick action to v1.0.9 (kserve#2735) Feat: adds huggingface bloom example to torchserve (kserve#2466) Adding podaffinity and resourcerequirments to IG Spec (kserve#2711) Update OWNERS (kserve#2724) Fix knative installation failure in e2e test (kserve#2726) Use fork in multiprocessing mode (kserve#2718) ...
Iamlovingit
pushed a commit
to Iamlovingit/kserve
that referenced
this pull request
Oct 1, 2023
Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixing tests after merging #2321 as some tests are using
kfswhile the multi-container runtime now requireskserve-containerWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: