Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rerunning failed workflows by comment #3550

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

andyi2it
Copy link
Contributor

@andyi2it andyi2it commented Mar 26, 2024

What this PR does / why we need it:

Re-running failed tests

The following commands are supported by this action:

/rerun-all - rerun all failed workflows.
/rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Some notes:

The PR either must have an ok-to-test label present on the PR, or the user who writes a command must be an organization member, or repo owner, contributor, or collaborator.
Typically ok-to-test can/should only be applied by repo reviewers/approvers to prevent spam and abuse.

Reference: https://github.com/estroz/rerun-actions

Fixes #3631

Type of changes
Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
NONE

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@andyi2it andyi2it changed the title Allow Allow rerunning failed workflows by comment Mar 26, 2024
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool. Can you test it in a fork and see if it works?

@terrytangyuan
Copy link
Member

Kubeflow uses /retest from prowbot. Perhaps we can enable that instead of adding a new workflow?

@andyi2it andyi2it marked this pull request as ready for review April 24, 2024 16:18
@yuzisun
Copy link
Member

yuzisun commented Apr 25, 2024

/lgtm
/approve

Copy link

oss-prow-bot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyi2it, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 47265b2 into kserve:master Apr 25, 2024
44 of 45 checks passed
@spolti
Copy link
Contributor

spolti commented Apr 25, 2024

This is very nice, will add it in the PR template so everyone can see that it is possible :)

cmaddalozzo added a commit to cmaddalozzo/kserve that referenced this pull request Apr 26, 2024
* master:
  Add OpenAI API support to Huggingfaceserver (kserve#3582)
  Allow rerunning failed workflows by comment (kserve#3550)
  Fix CVE-2023-45288 for qpext (kserve#3618)
  chore: v0.12.1 install files (kserve#3619)
  build: Fix CRD copying in generate-install.sh (kserve#3620)
  Fix Pydantic 2 warnings (kserve#3622)
  Fix make deploy-dev-storage-initializer not working (kserve#3617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants