-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE-2023-45288 for qpext #3618
Conversation
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
be0e23d
to
aa81e38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -103,7 +103,7 @@ require ( | |||
golang.org/x/crypto v0.21.0 // indirect | |||
golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa // indirect | |||
golang.org/x/mod v0.14.0 // indirect | |||
golang.org/x/net v0.21.0 // indirect | |||
golang.org/x/net v0.23.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it updated automatically (go mod tidy)?
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sivanantha321, terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* master: Add OpenAI API support to Huggingfaceserver (kserve#3582) Allow rerunning failed workflows by comment (kserve#3550) Fix CVE-2023-45288 for qpext (kserve#3618) chore: v0.12.1 install files (kserve#3619) build: Fix CRD copying in generate-install.sh (kserve#3620) Fix Pydantic 2 warnings (kserve#3622) Fix make deploy-dev-storage-initializer not working (kserve#3617)
Remove replace for golang.org/x/net and fix CVE-2023-45288 for qpext Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
What this PR does / why we need it:
Fixes CVE-2023-45288 for qpext
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: