Fix outdated Trition Transformer code #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Fu <xfu83@bloomberg.net>
Signed-off-by: Xin Fu <xfu83@bloomberg.net>
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yuzisun
reviewed
Aug 13, 2022
| # Here we reshape the data because triton always returns the flatten 1D array as json if not explicitly requesting binary | ||
| # since we are not using the triton python client library which takes care of the reshape it is up to user to reshape the returned tensor. | ||
| return {output["name"] : np.array(output["data"]).reshape(output["shape"]) for output in results["outputs"]} | ||
| return {output["name"]: np.array(output["data"]).reshape(output["shape"]).tolist() |
There was a problem hiding this comment.
still worth leaving the comments?
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xfu83, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuzisun
added a commit
that referenced
this pull request
Aug 13, 2022
* Sync trition transformer code Signed-off-by: Xin Fu <xfu83@bloomberg.net> * Add filename to the code snippet as title Signed-off-by: Xin Fu <xfu83@bloomberg.net> * Update release version Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Xin Fu <xfu83@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
rachitchauhan43
pushed a commit
to rachitchauhan43/website
that referenced
this pull request
Nov 21, 2022
* Sync trition transformer code Signed-off-by: Xin Fu <xfu83@bloomberg.net> * Add filename to the code snippet as title Signed-off-by: Xin Fu <xfu83@bloomberg.net> * Update release version Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Xin Fu <xfu83@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xin Fu xfu83@bloomberg.net
The issue is that the code snippet in "Implement pre/post processing functions" section is outdated and missing the
protocoloverride.Proposed Changes