Smattering of minor fixes #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed an oversight that caused ksh to needlessly override the native implementations of strlcpy and strlcat by failing to check for the existence of those functions. - Disabled the failing SIGBUS test on ASan because the design of the test isn't compatible with ASan's signal handling. - Added documentation for exit status 128 to 'ksh --man' output. - Mark b_dummy() with the noreturn attribute (re: 9f11f24). - Ignore .stackdump files that are generated in the repository while debugging on Cygwin. - Revise one of the regression tests that fails on Cygwin to print a more informative error message. - Fixed a dead link and revised some links to prefer HTTPS. - Other minor fixes for things such as typos.
McDutchie
reviewed
Jan 31, 2024
docs/ksh/builtins.html
Outdated
| @@ -1,4 +1,4 @@ | |||
| <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd"> | |||
| <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "https://www.w3.org/TR/REC-html40/loose.dtd"> | |||
There was a problem hiding this comment.
These doctype changes should not be made. Those aren't real URIs but XML namespace names.
Not all 128 errors are internal errors (e.g., out of memory and failure to read from the script are system errors). I don't think it's actually very useful to mention examples here; I prefer to keep it brief.
McDutchie
added a commit
that referenced
this pull request
Jan 31, 2024
Notable changes: src/lib/libast/features/lib: - Add missing strlcat and strlcpy lib tests. Their absence caused ksh to needlessly override the native implementations of strlcpy and strlcat (see string/strlc*.c). src/cmd/ksh93/data/builtins.c: sh_optksh[]: - Add documentation for exit status 128 to 'ksh --man' output. (These are the ERROR_PANIC errors.) src/cmd/ksh93/sh/parse.c: - Mark b_dummy() with the noreturn attribute (re: a19e1e9). src/cmd/ksh93/sh/path.c: path_spawn(): - Fix uninitialized variable if _lib_readlink is not present. src/cmd/ksh93/tests/signal.sh: - Disabled the failing SIGBUS test on ASan because the design of the test isn't compatible with ASan's signal handling. Co-authored-by: Martijn Dekker <martijn@inlv.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor accumulated changes:
strlcpyandstrlcatby failing to check for the existence of those functions.ksh --manoutput.b_dummy()with thenoreturnattribute (re: 9f11f24).sfsetbuftypo 'MAP_TUPE' was introduced in d2b3571).