Don't overwrite user-specified CFLAGS and CXXFLAGS #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible (however unlikely) that the C++ compiler might be clang but the C compiler might not be.
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a compile problem I noticed that your build was ignoring the CFLAGS and CXXFLAGS I had specified and using only its own (
-Wall). This fixes it by prepending-Wallto the user flags rather than overwriting them. This allows the user to override your flags at the command line if they want to.I also separated the C and C++ compiler checks. You were only checking if the C++ compiler is clang and using that result to decide what to do for both the C and C++ compiler. Now each is checked and handled individually.