Crashes on destruction

[tsdgeos]

• Run spectacle
• Close spectacle
• Crash

There is too much deleting of widgets and layouts going on, in particular the issue seems to be in FontPicker but there's too many deletes everywhere. In Qt you don't need to delete widgets or layouts to which you have given a parent, the destructor will take care of deleting them, you can delete them manually but you have to be careful of not double deleting, i.e if you delete mLayout, that will already delete mButtonLayout because it is it's child mLayout->addLayout(mButtonLayout) so when you do later delete mButtonLayout again it crashes because you have already deleted it.

My suggestion would be to not do manual deleting of QWidgets and just left the parent/child relationship cleanup everything.

[DamirPorobic]

Thanks for reporting, I'll have a look.

[thrimbor]

I have a backtrace from the Spectacle crash, in case that helps:
spectacle-20210529-174329.kcrash.txt

[DamirPorobic]

Thanks, I'll have a look into this issue tomorrow.

[eiglow]

Downstream bug report: https://bugs.kde.org/show_bug.cgi?id=437674

[DamirPorobic]

I have removed deletes of widgets and layouts where a parent was provided on construction. Would be nice if someone could test.

[thrimbor]

That does seem to have fixed it, Spectacle no longer crashes when closing.

[DamirPorobic]

Awesome, version is tagged now.

[dflogeras]

I also confirm the spectacle segfault is gone, thanks!