Ksnip window always visible on screenshots on Gnome Wayland #375
Comments
|
That should be actually working by default. I‘ve seen that sometimes the main window is not hidden fast enough and gets included in the screenshot, for example when running ksnip in a virtual machine. There is a default 200ms delay that is usually enough to hide the main window before taking the screenshot, maybe in your case its not enough. Can you try setting the delay to 1 second, if that works we need to provide a way for users to set the default delay to a custom value. If it doesn’t work, we might be facing a different issue.
…________________________________
From: g3blv <notifications@github.com>
Sent: Friday, July 10, 2020 8:36:51 PM
To: ksnip/ksnip <ksnip@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [ksnip/ksnip] Hide Ksnip app window when taking screenshots (#375)
It would be nice if the Ksnip app window was hidden while taking screenshots. At the moment I have to move the Ksnip app window to make sure it doesn't become part of the screenshot. Moving the window is harder on small screens since there is not a lot of room where it can be put to no be in the screenshot.
Not sure if this is a bug in the Appimage or a feature that could be added. I've tried looking for a setting to enable it but haven't found one.
Using
Appimage
Version: 1.7.0
Build: 1238-caa6fa9
OS: Fedora 32
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#375>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADBUCTHASVARKI33KQLSFMDR25NUHANCNFSM4OW2VRNQ>.
|
|
I made a short video. The issue seems more like the Ksnip app window is hidden for a short while and then comes back. I'm happy to provide more info or testing if needed.
|
|
Ok, interesting. The main window doesn‘t actually pop back up, what’s happening ist that we create a screenshot of the full desktop and show that as background for the snipping area. You can try something else, disable the „Freeze Background while snipping“ option, that should skip the first screenshot which in your case seems to ignore the default delay. With that disabled we skip the background screenshot and show a transparent widget instead. Anyway looks kind of strange, I‘ll have a look at it myself after my vacation (writing you from my mobile right now).
…________________________________
From: g3blv <notifications@github.com>
Sent: Saturday, July 11, 2020 10:06:23 AM
To: ksnip/ksnip <ksnip@noreply.github.com>
Cc: Damir Porobic <damir_porobic@live.com>; Comment <comment@noreply.github.com>
Subject: Re: [ksnip/ksnip] Hide Ksnip app window when taking screenshots (#375)
I made a short video. The issue seems more like the Ksnip app window is hidden for a short while and then comes back. I'm happy to provide more info or testing if needed.
[Ksnip issue]<https://user-images.githubusercontent.com/45568043/87219717-f9e30100-c35d-11ea-8be7-593e58d9a47c.gif>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#375 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADBUCTG23NXUUGLLNGNADC3R3AMP5ANCNFSM4OW2VRNQ>.
|
|
I wasn't able find "Freeze Background while snipping" but I found "Freeze image while snipping" and it is already disabled. Enjoy your holiday ;)
|
|
Oh, you're using Wayland maybe? |
|
Yes I'm using Wayland. |
|
Ok, I can reproduce that but only under Gnome Wayland. Under Gnome X11 it seems to be working and under Plasma Wayland we can't take rect screenshots. |
|
I think I found the issue. Usually we minimize to the task bar and hide the window, but it looks like Wayland is not happy with minimizing. With the change below it's working for me in my Fedora VM.
Does Wayland/Gnome support minimizing application? |
|
I tested Ksnip AppImage on Ubuntu 20.04 desktop using Wayland. Ubuntu is using minimize buttons on all windows. I was able to minimize Ksnip by clicking the minimize button on Ubuntu. |
|
Do you have there the same behavior that ksnip is visible on screenshots? |
|
Maybe we should generally switch setting visibility? I'll look into it tonight again, we should have a test version by end of the day. |
|
Yes same behaviour. |
|
Can you test with latest appImage? For me it's working with this code change on fedora 31. Just give the CI a couple of minutes to finish building the binaries. |
|
I had a look on https://github.com/ksnip/ksnip/releases/tag/continuous for the latest AppImage but there is only EXE, DEB, RPM, DMG and source code. I also looked in CI/Travis but couldn't find any AppImage there. Am I looking in the wrong places? |
|
Sorry, something went wrong with the upload script. I've restarted the build process and not it's there. |
|
I tested the AppImage for 1.7.2 (it says build 12238-caa6fa9 in About - Version, I'm not sure if this updates for the continuous builds) now on Fedora 32. Still the same issue. Looks like the window is minimizing for a short while but then comes back again.
|
|
Doesn't look right, the commit hash under about seems to be wrong. Sorry, will look into it after work. |
|
I get the latest version from the release page |
|
Now I have the same version and commit and I can confirm that the Ksnip app minimize when I take a screenshot. Great! Thanks! I really enjoy using Ksnip. I used to use Shutter but it doesn't support Wayland. Ksnip works just as well for me on Wayland. Should I close this issue? |
|
I want to do a a small refactoring as I have changed the behavior for all version but the fix we need actually only for gnome Wayland. After I have pushed that changed I will close it. I might ask you to test the final fix once again. Thanks for confirming. Yes, I hear a lot of people coming from Shutter and I kind of target those users with features and try to implement what they had with Shutter in order to make the transition easier. |
|
Sure I'm happy to test after refactoring. Great, my transition have been very smooth from Shutter to Ksnip. |
DamirPorobic
changed the title
|
I have pushed a new commit, the new behavior should only be used for gnome wayland and all other platforms end distros should be using the old behavior. You could just double check that it's still working as expected. |
|
I've tested latest continues build Version: 1.7.2-continuous On Fedora 32 using Gnome and Wayland And it is working as expected. Thanks for fixing the issue. |
|
Thanks for testing and confirming :) |
It would be nice if the Ksnip app window was hidden while taking screenshots. At the moment I have to move the Ksnip app window to make sure it doesn't become part of the screenshot. Moving the window is harder on small screens since there is not a lot of room where it can be put to no be in the screenshot.
Not sure if this is a bug in the Appimage or a feature that could be added. I've tried looking for a setting to enable it but haven't found one.
Using
Appimage
Version: 1.7.0
Build: 1238-caa6fa9
OS: Fedora 32
The text was updated successfully, but these errors were encountered: