About dialog not closing when close button is clicked

[zensubz]

Hi,
Compiled the git-snapshot 82e4142. Just a small issue with the 'About' dialog. It doesn't seem to close when I click on 'Close'.

Thanks for developing this nice screenshot tool..!

[DamirPorobic]

Well, that definitely doesn't look right xD
Thanks for reporting, I'll have a look into that.

[zensubz]

The following patch seems to work in my case:

--- ksnip-82e4142/src/gui/AboutDialog.cpp
+++ ksnip-82e4142/src/gui/AboutDialog.cpp.new
@@ -43,7 +43,7 @@
     mTabWidget->setMinimumSize(mTabWidget->sizeHint());
 
     mCloseButton->setText(tr("Close"));
-    connect(mCloseButton, &QPushButton::clicked, &AboutDialog::close);
+    connect(mCloseButton, &QPushButton::clicked, this, &AboutDialog::close);
 
     mMainLayout->addLayout(mHeaderLayout);
     mMainLayout->addWidget(mTabWidget);

I am not sure if any other dialog with 'Close' is affected...

[DamirPorobic]

Yes indeed, that was the issue, I must have broken it while moving from Qt4 to Qt5. It should be working now. Thanks again for reporting and providing the patch.