New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component in module with #796

Merged
merged 1 commit into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@bryanl
Member

bryanl commented Jul 30, 2018

Removes component in module with ks component rm module.name. The previous behavior did not respect the module name.

#795

Signed-off-by: bryanl bryanliles@gmail.com

@bryanl bryanl self-assigned this Jul 30, 2018

@bryanl bryanl requested a review from ksonnet/reviewers Jul 30, 2018

@bryanl bryanl closed this Jul 30, 2018

@bryanl bryanl reopened this Jul 30, 2018

@coveralls

This comment has been minimized.

coveralls commented Jul 30, 2018

Pull Request Test Coverage Report for Build 1249

  • 26 of 40 (65.0%) changed or added relevant lines in 6 files are covered.
  • 18 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 71.07%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/component/component.go 1 2 50.0%
pkg/component/jsonnet.go 5 7 71.43%
pkg/component/delete.go 18 22 81.82%
pkg/component/yaml.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/component/component.go 18 15.63%
Totals Coverage Status
Change from base Build 1247: -0.1%
Covered Lines: 11971
Relevant Lines: 16844

💛 - Coveralls
@shomron

This comment has been minimized.

Collaborator

shomron commented Jul 30, 2018

Looks good, no blockers.

There are a two edge cases we may want to address in followups -

  • Missing component file (foo.jsonnet) causes failure, but missing component reference in params.jsonnet does not. Do we want to gracefully recover so that when one or the other is out of sync the user can still remove the remaining parts?
  • If a component is ambiguous (foo.jsonnet, foo.yaml both exist), one will be arbitrarily removed and the other will remain
@bryanl

This comment has been minimized.

Member

bryanl commented Jul 30, 2018

@shomron I created #799 to track the points you brought up.

Remove component in module with
Removes component in module with `ks component rm module.name`

Signed-off-by: bryanl <bryanliles@gmail.com>

@bryanl bryanl merged commit b6b33c5 into ksonnet:master Jul 30, 2018

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.1%) to 71.07%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
signed-off-by Commit has Signed-off-by
Details

@bryanl bryanl deleted the bryanl:remove-component branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment