Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10.x sections showing up in 1.x section #23

Merged
merged 1 commit into from
Mar 6, 2013

Conversation

mscheibe
Copy link

@mscheibe mscheibe commented Mar 5, 2013

  • The eachSection regex was allowing more sections to qualify than it
    should have.
  • For example, when rootNumber is 1, sections labeled 10.* and 10
    were also matching, thus having all the sections for 10 repeated
    under section 1.
  • This update will have it now match either '1', '1.', or '1.*'

Test suite still passed and sections now show up correctly.

* The eachSection regex was allowing more sections to qualify than it
  should have.
* For example, when rootNumber is 1, sections labeled 10.* and 10
  were also matching, thus having all the sections for 10 repeated
  under section 1.
* This update will have it now match either '1', '1.', or '1.*'

Test suite still passed and sections now show up correctly.
hughsk added a commit that referenced this pull request Mar 6, 2013
Fix 10.x sections showing up in 1.x section
@hughsk hughsk merged commit b7d2e81 into kss-node:master Mar 6, 2013
@hughsk
Copy link
Member

hughsk commented Mar 6, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants