Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix 10.x sections showing up in 1.x section #23

Merged
merged 1 commit into from Mar 6, 2013

Conversation

Projects
None yet
2 participants

mscheibe commented Mar 5, 2013

  • The eachSection regex was allowing more sections to qualify than it
    should have.
  • For example, when rootNumber is 1, sections labeled 10.* and 10
    were also matching, thus having all the sections for 10 repeated
    under section 1.
  • This update will have it now match either '1', '1.', or '1.*'

Test suite still passed and sections now show up correctly.

Fix 10.x sections showing up in 1.x section
* The eachSection regex was allowing more sections to qualify than it
  should have.
* For example, when rootNumber is 1, sections labeled 10.* and 10
  were also matching, thus having all the sections for 10 repeated
  under section 1.
* This update will have it now match either '1', '1.', or '1.*'

Test suite still passed and sections now show up correctly.

hughsk added a commit that referenced this pull request Mar 6, 2013

Merge pull request #23 from mscheibe/master
Fix 10.x sections showing up in 1.x section

@hughsk hughsk merged commit b7d2e81 into kss-node:master Mar 6, 2013

1 check passed

default The Travis build passed
Details
Owner

hughsk commented Mar 6, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment