Compass Sprite imports break KSS parsing #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Compass Sprite imports can be of the form `@import "folder/*.png"`. * This matches the regex for multi-line comments and the rest of the file would then be ignored. * New behaviour is to `continue` if we aren't already in a multi-line comment if the line starts with @import. * Ran mocha test suite and still passed. * Manually verified as well.
5 tasks
|
Thanks for the bug report! In addition to the problem you noted, kss-node fails to detect "/_" inside CSS strings, e.g. The problem is with the regular expressions that detect the start of multi-line comments. I'm working on some tests to confirm my fix. |
|
Fixing this over in #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@import "folder/*.png".file would then be ignored.
continueif we aren't already in a multi-linecomment if the line starts with @import.