Skip to content

Fix multiline comment start #80

Merged
merged 2 commits into from Jul 21, 2014

1 participant

@JohnAlbin

Over in #24, @mscheibe noted that:

Compass Sprite imports can be of the form @import "folder/*.png". This matches the regex for multi-line comments and the rest of the file would then be ignored.

Looking at this more closely, I see that other, similar strings can cause the same failure:

  • .rule { content: "/*"; }
  • /* A multi-line comment on a single line */

Properly parsing CSS strings and comments is a difficult task. Fortunately, the KSS spec implies that we only should care about clean multi-line comments that start and end on their own lines. This is much easier to match with regex.

@JohnAlbin JohnAlbin merged commit 2f8f170 into master Jul 21, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@JohnAlbin JohnAlbin added this to the 1.0.0 milestone Jul 21, 2014
@JohnAlbin JohnAlbin deleted the fix-multiline-comment-start branch Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.