Fix NoMethodError at Orthoses::ActiveRecord::Scope middleware #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing callable object to scope e.g. using Query Object Pattern c.f. https://takaokouji.github.io/output/query-object/ ```ruby class FilterByStatusQuery private attr_reader :relation, :options def self.call(*args) new(*args).send(:query) end def initialize(*args) @options = args.extract_options! @relation = Blog end private def query relation.where(status: options[:status]) end end class Blog < ApplicationRecord scope :by_status, FilterByStatusQuery end ``` Orthoses raises NoMethodError because Class doesn't respond to parameters ``` $ bin/rails orthoses:rails ... Caused by: NoMethodError: undefined method `parameters' for FilterByStatusQuery:Class (NoMethodError) definition = "#{name}: #{parameters_to_type(body.parameters)} -> #{base_name}::ActiveRecord_Relation" ^^^^^^^^^^^ ``` So captured argument body is not Proc and callable, we should use Method#parameters
ksss
reviewed
Nov 4, 2023
c.f. https://github.com/ksss/orthoses-rails/pull/18/files#r1382400198 > In Rails, it seems to branch based on the presence of `#to_proc`. Also, since the `#call` presence is checked by the `#scope`, it seems unnecessary to check for `#call` here. Therefore, how about making the following correction? > > ref: https://github.com/rails/rails/blob/8c82595b8c862eb087615a14f61ded528274eeae/activerecord/lib/active_record/scoping/named.rb#L173-L185 Co-authored-by: Yuki Kurihara <co000ri@gmail.com>
|
@sanfrecce-osaka I released v1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing callable object to scope
e.g. using Query Object Pattern
c.f. https://takaokouji.github.io/output/query-object/
Orthoses raises NoMethodError because Class doesn't respond to parameters
So captured argument body is not Proc and callable, we should use Method#parameters