Fix unimplemented instruction cycles #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the M68000UM, the two unimplemented instruction exceptions both cost 34 cycles, not 4. Actually, that's a bit of a lie. Table 8-14. Exception Processing Execution Times does not even mention unimplemented instruction exceptions, but section 6.3.6 Illegal and Unimplemented Instructions basically says that unimplemented instructions are just a special case of illegal instructions in that they have separate exception vectors.
marhel
added a commit
to marhel/r68k
that referenced
this pull request
Apr 28, 2016
This version integrates the following exception related Musashi PRs; * Fix address error cycle count and cycle depletion behavior (kstenerud/Musashi#20) * Undo instruction cycles in trap exception (kstenerud/Musashi#21) * Undo instruction cycles in trap#n exception (kstenerud/Musashi#22) * Fix unimplemented instruction cycles (kstenerud/Musashi#23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the M68000UM, the two unimplemented instruction exceptions
both cost 34 cycles, not 4.
Actually, that's a bit of a lie. Table 8-14. Exception Processing
Execution Times does not even mention unimplemented instruction
exceptions, but section 6.3.6 Illegal and Unimplemented Instructions
basically says that unimplemented instructions are just a special case
of illegal instructions in that they have separate exception vectors.