Add PHP7 to TravisCI configuration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you posted your pull request, Imagick 3.4.0 RC4 has been released with PHP 7 support. So we should use this version by installing it with pear instead of compile it from source. |
ksubileau
added a commit
that referenced
this pull request
Jan 8, 2016
Add PHP7 to TravisCI configuration
ksubileau
added a commit
that referenced
this pull request
Jan 8, 2016
|
Done, thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a released version of imagick with PHP7 support, so here I compile it from the git branch. Change to VBox.php was a phpcs fix. phpcs is being installed via composer, so it shouldn't be necessary to install it with pyrus.