forked from browsermedia/browsercms
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for my styling edits for the create new page #1
Open
ksung
wants to merge
163
commits into
ksung:design
Choose a base branch
from
browsermedia:master
base: design
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow editors to create form pages that can be used to collect information from visitors (i.e. Contact Us, Support requests, etc). Basically, any quick collect a few fields using a consistent form styling. h2. Features include: 1. Forms can have multiple fields which can be text fields, textareas or multiple choice dropdowns. Field management is done via AJAX and fields can be added/reordered/removed without leaving the page. 2. Fields can be required, have instructions and default values. Choices are added as lines of text for each dropdown field. Dropdowns use the first value as the default. 3. Entries are stored in the database and can optionally notify someone via email when new submissions are created. 4. Editors can manage entries via the admin (CRUD) 5. Visitors can be redirected to another URL after submitting their entry or display a customizable 'success' message. 6. Forms generate the HTML display using bootstrap's CSS by default. Projects can customize this in the application.rb with config.cms.form_builder_css h2. Refactorings * Created a 'spec' directory and 'rake spec' tasks to run minitest specs. * All content blocks are now namespaced (and will be generated as such). Blocks created in projects will be namespaced under the project name. This consistency allows use to use Rails standard polymorphic_paths for content blocks, while being able to easily deterimine which 'Engine' the block belongs to. * Projects will need to modify their existing contentblocks to move them under the project namespace. * Moved all 'testing' content types under the 'Dummy' namespace. * Added 'engine_aware_path' method that works like 'polymporphic_path' but can guess the engine that the resource belongs to. A number of old path generating helpers were removed including block_path/blocks_path/new_block_path/cms_connectable_path. See app/helpers/cms/path_helper.rb for new methods. * Add 'Cms::BaseController#allow_guests_to' which provides a way to selectively have actions be publicly available. * Added concept of mailbot_address which is used by default for system generated emails. Worked based on 'config.cms.site_domain' by default, but can be configured via config.cms.mailbot.
Add form builder details.
…owsercms into jtwohiou-delete_page_notification_bug
…jjbohn-fix/display_name
…jdurand-upstream/master
* Ensure unique slugs: Addressable Content types that use slugs should ensure they are unique. * Speed up specs by avoiding repeated table creation. * Overrideable Templates: Addressable content types can have their default content type have their template configured in the application.rb. Example: config.cms.templates['cms/form'] = 'custom-forms'
Implement new design for new page. * Reduce layout count to just two (application and page_editor) * Apply styling to most pages. * Style form elements on new/edit page. * Add better hints (Caching, Page Title) * Implement Cancel, Publish and Save Draft Buttons * Implement visibility selector rather than checkboxes. * Rename Sitemap main menu nav to Pages * Hide sidebar features from design that aren't yet implemented.
Just a while bunch of files updated, glyphs correct location, etc
Other general design adjustements
Fixes 4.0.0.rc1 tests
…ng callbacks and removing deprecation warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.