Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working directory is used as root directory instead of actual root directory #100

Closed
lukoerfer opened this issue Jan 3, 2020 · 0 comments · Fixed by #108
Closed

Working directory is used as root directory instead of actual root directory #100

lukoerfer opened this issue Jan 3, 2020 · 0 comments · Fixed by #108

Comments

@lukoerfer
Copy link

There is a line in JacocoSourceReportFactory that relativizes the paths of the source files. It uses new File(".") as root directory, which defaults to the current working directory of the JVM process that runs Gradle. There is no guarantee that this working directory is the root of the repository or the root of the Gradle project, as for example gradlew may run the process from another directory. When this happens, the coveralls task sends the absolute file paths to Coveralls. The line should be changed to use project.rootDir instead of new File(".").

hurricup added a commit to hurricup/coveralls-gradle-plugin that referenced this issue Aug 6, 2020
…f current dir

Current directory may be some daemon working dir, not a project one

This should fix: kt3k#100
@kt3k kt3k closed this as completed in #108 Aug 7, 2020
kt3k pushed a commit that referenced this issue Aug 7, 2020
…f current dir (#108)

Current directory may be some daemon working dir, not a project one

This should fix: #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant