Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failures when building against a new kernel and toolchain #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix failures when building against a new kernel and toolchain #107

wants to merge 2 commits into from

Conversation

leitao
Copy link

@leitao leitao commented Sep 2, 2018

No description provided.

@leitao
build: Fixes on gcc-8, defining cycle_T
65923a4 
Additional gcc-8 checks make ktap to fail to build, since cycle_t is undefined
and gcc-8 was picky, showing:

	..ktap/runtime/kp_transport.c:120:29: error: unknown type name ‘cycle_t’; did you mean ‘cycles_t’?
	 unsigned long long ns2usecs(cycle_t nsec)
				     ^~~~~~~
				     cycles_t
	../ktap/runtime/kp_transport.c: In function ‘trace_print_timestamp’:
	../ktap/runtime/kp_transport.c:133:6: error: implicit declaration of function ‘ns2usecs’ [-Werror=implicit-function-declaration]
	  t = ns2usecs(iter->ts);
	      ^~~~~~~~
@leitao
Replace strlen_user to strnlen_user
b2651aa 
strlen is not being exported on new kernel, failing when the ktap module is
loaded, with the following error:

	[175162.784801] ktapvm: Unknown symbol strlen_user (err 0)

This module just replace the strlen_user function for strnlen_user, which is a
safer function and it continues to be exported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leitao