-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Audiocode Driver #2869
Updated Audiocode Driver #2869
Conversation
fixing conflicts in ssh_dispatcher.py
@Gatorjosh14 I updated the PR adding the type hints here. Other big/meaningful changes:
So The
|
@Gatorjosh14 Feel free to review and let me know if you see issues. Once we decide the code is in a state that we both think is acceptable...it would be really good to run the unit tests one more time. |
@Gatorjosh14 Any update on this? We should really complete this before working on the next driver (the Fortinet driver). If you are okay with the changes that I made then it would be great if you could run the Netmiko test suite again using this latest code (to make sure I didn't break anything). |
I'll pull the code down, look it over and test it out. I'm fine with finishing this one up before Fortinet. |
…_config_mode is True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixes Type Hinting
Tries to make things more consistent with expected netmiko behavior
Restructures audiocode class hierarchy