Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review flags that are supplied (not only) from user space #4

Closed
fridex opened this issue Apr 6, 2016 · 2 comments
Closed

Review flags that are supplied (not only) from user space #4

fridex opened this issue Apr 6, 2016 · 2 comments

Comments

@fridex
Copy link
Member

fridex commented Apr 6, 2016

Review flags that can be supplied (e.g. MSG_NONBLOCK, MSG_MORE, etc.). Some of them are not useful for TLS/DTLS, but some are. Some ideas:

  • MSG_DONTWAIT - for sendmsg(2) can be implemented with a worker
  • MSG_MORE - has to store previous bytes - sendpage() context can be reused for
    this purpose
  • MSG_NOSIGNAL - can be propagated when suitable
  • MSG_PEEK -this will require not to clear cached record if received
    asynchronously or write to cache when waited for data (in
    kernel_recvmsg() rx queue)
  • MSG_WAITALL - this can be tricky, a use case when a user supplies more than
    TLS_MAX_PAYLOAD_SIZE (1 << 14) should be not supported from my POV
  • ...
@fridex
Copy link
Member Author

fridex commented Apr 27, 2016

  • MSG_ERRQUEUE could be used to explicitly probe for encrypted record causing error (not to read it from bound socket) - this is overkill for uses pace to handle and I don't like it though

@djwatson
Copy link
Member

#84 should handle MSG_DONTWAIT, MSG_MORE. MSG_PEEK should already be implemented. I agree MSG_ERRQUEUE and MSG_WAITALL don't make much sense. I think the sk_wait handling already takes care of MSG_NOSIGNAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants