Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsing subtrees is inefficient and slow #35

Closed
ktmeaton opened this issue Jun 20, 2022 · 3 comments
Closed

Collapsing subtrees is inefficient and slow #35

ktmeaton opened this issue Jun 20, 2022 · 3 comments
Assignees
@ktmeaton
Labels
enhancement New feature or request
Milestone
v0.3.0

Comments

@ktmeaton
Copy link
Owner

This became apparent once I hit the 400+ sample range.
@ktmeaton ktmeaton self-assigned this Jun 20, 2022
@ktmeaton ktmeaton added the enhancement New feature or request label Jun 20, 2022
@ktmeaton ktmeaton added this to the v0.3.0 milestone Jun 20, 2022
@ktmeaton
Copy link
Owner Author

  • I am doing way too many file comparisons with filecmp.cmp()
  • Instead, I'll just compare the strains that are in each file.

@ktmeaton
Copy link
Owner Author

I might as well also work on Issue #20 while I'm updating this script.

ktmeaton pushed a commit that referenced this issue Jun 20, 2022
improve subtree collapse effiency (#35) and output aesthetics (#20)
5b2430e
@ktmeaton
Copy link
Owner Author

Verified by continuous integration in Pipeline 2530317802.

@ktmeaton ktmeaton mentioned this issue Jun 21, 2022
Closed
ktmeaton pushed a commit that referenced this issue Jun 21, 2022
improve subtree collapse effiency (#35) and output aesthetics (#20)
3e30685
@ktmeaton ktmeaton mentioned this issue Jun 21, 2022
Merged
ktmeaton pushed a commit that referenced this issue Jun 21, 2022
@ktmeaton
improve subtree collapse effiency (#35) and output aesthetics (#20)
2511673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktmeaton ktmeaton

Labels
enhancement New feature or request
Projects
ncov-recombinant
Status: Done
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@ktmeaton