-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.0 stability update #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
Default parameters have been updated! Please regenerate your profiles/builds with:
Rule outputs are now in sub-directories for a cleaner
results
directory.The in-text report (
report.pptx
) statistics are no longer cumulative counts of all sequences. Instead they, will match the reporting period in the accompanying plots.Bug Fixes
extra_cols
(column "gisaid_epi_isl" not existed in file #26).Workflow
usher_columns
to augment the base usher metadata.parents.py
, plots, and report slide to summarize recombinant sequences by parent.plot
andreport
more dynamic with regards to plots creation.faToVcf
.create_profile.sh
script.--low-memory
mode parameter within the scriptusher_metadata.sh
.Data
Create new controls datasets:
controls-negatives
controls-positives
controls
Add versions to
genbank_accessions
forcontrols
.Programs
taxonium
andchronumental
from the conda env.Parameters
Add parameters to control whether negatives and false_positives should be excluded:
exclude_negatives: false
false_positives: false
Add new optional param
max_placements
to rulelinelist
.Remove
--show-private-mutations
fromdebug_args
of rulesc2rf
.Add optional param
--sc2rf-dir
tosc2rf
to enable execution outside ofsc2rf
dir.Add params
--output-csv
and--output-ansi
to the wrapperscripts/sc2rf.sh
.Remove params
nextclade_ref
andcustom_ref
from rulenextclade
.Change
--breakpoints 0-10
insc2rf
.Continuous Integration
Re-rename tutorial action to pipeline, and add different jobs for different profiles:
Output
Output new
_historical
plots and slides for plotting all data over time.Output new file
parents.tsv
to summarize recombinant sequences by parent.Order the colors/legend of the stacked bar
plots
by number of sequences.Include lineage and cluster id in filepaths of largest plots and tables.
Rename the linelist output:
linelist.tsv
positives.tsv
negatives.tsv
false_positives.tsv
lineages.tsv
parents.tsv
The
report.xlsx
now includes the following tables: