Expose servlet request attributes as call attributes #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
The opinion of stale[bot] notwithstanding, I'd still like to see this merged.... |
|
Merged as part of #2234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
ktor-server-servlet
Motivation
KTOR-424 Get client certificate information from request
This implements feature request #1767 by exposing servlet request attributes as call attributes
Solution
On instantiating a ServletApplicationRequest from a HttpServletRequest, the attributes in the servlet request are extracted and stored in the call attributes using a key that is exposed in a companion object to ServletApplicationRequest.
Note that the map with servlet attributes is also stored as a property on ServletApplicationRequest. This currently serves no purpose but has been done to be symmetrical to the headers. But one could certainly argue this is not useful