-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native-mt support for CIO client #2021
Conversation
ktor-network/jvm/src/io/ktor/network/sockets/DatagramSocketImpl.kt
Outdated
Show resolved
Hide resolved
ktor-network/jvm/src/io/ktor/network/sockets/DatagramSocketImpl.kt
Outdated
Show resolved
Hide resolved
9ba9acf
to
3963ef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check all .api files: there seem to be remove and change operations in diff signalling that there might be breaking changes.
c9a1baa
to
c64977c
Compare
This is wonderful, however, the following line in the release notes is hard to understand for those who have no idea what CIO is:
Please un-abbreviate the used acronyms at least once. Than you. |
Just upgraded to latest Ktor and the change in MockEngine to using ConcurrentList for storing request and response history is annoying. I have tests where I want to see how many times a particular call was made (I am testing some caching logic) using a method like this:
That now fails because ConcurrentList does not support an iterator. |
@dalewking could you please file an issue in Youtrack with the full sample code attached? |
Don't see the point of sample code. The issue is simple. The object backing requestHistory and responseHistory were changed by this PR from MutableList to ConcurrentList and you can see right here that ConcurrentList does not support an iterator. So this is a regression in the features of requestHistory and responseHistory. That may be acceptable, but it isn't even documented. |
@dalewking I've created a Youtrack issue about this problem. |
No description provided.