Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-3656 Use secure random for nonce generation #2776

Merged
merged 4 commits into from
Mar 10, 2022
Merged

KTOR-3656 Use secure random for nonce generation #2776

merged 4 commits into from
Mar 10, 2022

Conversation

rsinukov
Copy link
Contributor

No description provided.

@rsinukov rsinukov requested a review from e5l January 17, 2022 13:53
@rsinukov rsinukov self-assigned this Jan 17, 2022
e5l
e5l requested changes Jan 18, 2022
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the compilation error for benchmarks?

https://ktor.teamcity.com/buildConfiguration/Ktor_AllocationTests/62594?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true

@rsinukov rsinukov marked this pull request as draft January 24, 2022 00:42
@rsinukov
Copy link
Contributor Author

Hi @danwallach
Thanks for your comments. This PR is still in draft and I opened it just for checking that it works on different platform and OS. I'll address your comments before merging.

@lolilofit lolilofit marked this pull request as ready for review March 3, 2022 07:23
@lolilofit lolilofit requested a review from e5l March 3, 2022 09:08
e5l
e5l approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rsinukov
rsinukov commented Mar 7, 2022
View reviewed changes
ktor-utils/js/src/io/ktor/util/CryptoJs.kt Outdated
@@ -8,7 +8,7 @@ import kotlinx.coroutines.*
import org.khronos.webgl.*
import kotlin.js.*

private const val NONCE_SIZE_IN_BYTES = 8
private const val NONCE_SIZE_IN_BYTES = 16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please extract to common internal constant

@lolilofit lolilofit merged commit 67a3640 into main Mar 10, 2022
@lolilofit lolilofit deleted the rsinukov/secure-nonce branch March 10, 2022 11:15
andreyaksenov pushed a commit that referenced this pull request Mar 10, 2022
@rsinukov
KTOR-3656 Use secure random for nonce generation (#2776)
593ce65
@danwallach
Copy link

Feature request: expose the secureRandom method (currently internal expect fun secureRandom(bytes: ByteArray)) as a public part of the API. This would make it useful for applications, like mine, that need a portable way to get secure random bytes, for their own cryptographic needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees

@rsinukov rsinukov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsinukov @danwallach @e5l @lolilofit