-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-3656 Use secure random for nonce generation #2776
Conversation
00e9f88
to
502a757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check the compilation error for benchmarks?
Hi @danwallach |
502a757
to
e391e7e
Compare
e391e7e
to
4a3e335
Compare
2e6aef6
to
40c8528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -8,7 +8,7 @@ import kotlinx.coroutines.* | |||
import org.khronos.webgl.* | |||
import kotlin.js.* | |||
|
|||
private const val NONCE_SIZE_IN_BYTES = 8 | |||
private const val NONCE_SIZE_IN_BYTES = 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please extract to common internal constant
5a46d5d
to
6e701f8
Compare
Feature request: expose the |
No description provided.