ktor-client-core: Copy existing config in HttpClient#config #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
requested changes
Sep 4, 2018
|
Sure, though I don't see the advantage -- don't all of them use the same |
|
The test class locates in |
Copy the existing config in HttpClient#config, as the docs specify. Prior to this all features and interceptors were lost.
octylFractal
force-pushed
the
bugfix/http-client-config-copy
branch
from
e28f74e
to
38e8a6e
Compare
|
Added engine test runners. |
|
LGTM. Awesome, thanks for the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the existing config in HttpClient#config, as the docs specify.
Prior to this all features and interceptors were lost.