Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to extract zipped symlinks as symlinks on UNIX platform #84

Merged
merged 5 commits into from
Nov 3, 2018

Conversation

bvgastel
Copy link
Contributor

Included the ability to extract symlinks, as this is needed in my use case. I did not include the ability to zip symlinks, as I did not need it.

If any changes are needed, I'm happy to make them.

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #84 into master will decrease coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   60.56%   60.53%   -0.04%     
==========================================
  Files           4        4              
  Lines        3444     3451       +7     
==========================================
+ Hits         2086     2089       +3     
- Misses       1358     1362       +4
Impacted Files Coverage Δ
src/zip.c 72.26% <60%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64aa7b4...a384fa9. Read the comment docs.

@kuba--
Copy link
Owner

kuba-- commented Oct 26, 2018

@bvgastel - thanks, cool.
Could you add a test for symlinks?

@bvgastel
Copy link
Contributor Author

That is a bit difficult, as currently the pull request can only decompress symlinks. I will think about it.

src/zip.c Outdated Show resolved Hide resolved
@kuba-- kuba-- added the enhancement New feature or request label Oct 26, 2018
- Rename symlinkTo to symlink_to
- Move it on the top of function
- memset
@kuba-- kuba-- merged commit 0f99444 into kuba--:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants