Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create cluster load balancer with terraform #1001

Merged

Conversation

schlichtanders
Copy link
Contributor

@schlichtanders schlichtanders commented Sep 30, 2023

The official hcloud-cloud-controller-manager documentation states that you can also predefine your load balancer with terraform.

Advantages:

  • load balancer is created slightly faster
  • terraform destroy destroys everything - no need for cleanup any longer cleanup is no longer needed for the load balancer

This pull-requests also includes a slight update to the restoration readme (restoration was again failing for me on recent updates - I updated the documentation to reflect the extra changes to make it more stable)

EDIT: I tested the creation and everything runs through without problems

@schlichtanders
Copy link
Contributor Author

schlichtanders commented Sep 30, 2023

I need to correct my statement:

  • while terraform destroy completes successfully, the firewall and only the network is not deleted - so the cleanup is still needed

@mysticaltech
Copy link
Collaborator

I need to correct my statement:

  • while terraform destroy completes successfully, the firewall and only the network is not deleted - so the cleanup is still needed

Yes, that would make sense, they do stick around because of the autoscaled nodes maybe.

@mysticaltech
Copy link
Collaborator

@schlichtanders Thanks for this, I remember us talking about it. It's awesome. However can you confirm that both traefik and nginx, the ingress controllers, will take that already created lb and apply the custom settings they have, like all the hetzner lb annotations (see kube.tf.example traefik and nginx helm values), including for the hostname?

@schlichtanders
Copy link
Contributor Author

Dear @mysticaltech I can confirm for traefik, that everythings runs without problems - I have deployed my cluster using this branch.
Also Autoscaling works, really everything works so far I can see. I haven't tested nginx, but because it uses the same hcloud go routines under the hood, it should indeed do the very same.

@mysticaltech
Copy link
Collaborator

Ok wonderful, good to hear, I will try nginx myself.

@kube-hetzner/core FYI Big positive evolution in this PR!

Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@mysticaltech mysticaltech changed the base branch from master to staging October 11, 2023 12:58
@mysticaltech mysticaltech merged commit 2dfac3f into kube-hetzner:staging Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants