Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts,logging-operator): add possibility to deploy extra manife… #1768

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

sebastiangaiser
Copy link
Contributor

…sts to Helm chart

…sts to Helm chart

Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
@sebastiangaiser
Copy link
Contributor Author

sebastiangaiser commented Jul 1, 2024

@pepov maybe you can include that in the upcomming release tomorrow :D
Sorry for pushing that but I saw changes on the planned features for the next release.

@pepov
Copy link
Member

pepov commented Jul 1, 2024

@sebastiangaiser what is the usecase for this? what is the reason against creating an umbrella chart and putting extra resources there?

@sebastiangaiser
Copy link
Contributor Author

sebastiangaiser commented Jul 1, 2024

My use case are the PrometheusRules from here. But I think this could also make sense in case you want to have some ConfigMap mounted via volume into FluentD, too.
I didn't get what you meant with the umbrella chart

@pepov
Copy link
Member

pepov commented Jul 1, 2024

I meant that you can create a high level chart, add you prometheus resources and add the logging operator as a dependency into that. I haven't really seen this extra resources as a practice this is why I ask.

The term comes from here: https://helm.sh/docs/howto/charts_tips_and_tricks/#complex-charts-with-many-dependencies

@pepov
Copy link
Member

pepov commented Jul 1, 2024

I've found a few usage for this in the most popular charts, ok for me

@pepov pepov merged commit 83d50ae into kube-logging:master Jul 2, 2024
17 checks passed
@sebastiangaiser sebastiangaiser deleted the feature/extra-manifests branch July 2, 2024 07:07
@pepov pepov added the enhancement New feature or request label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants