-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Separate Helm Charts #92
base: master
Are you sure you want to change the base?
Conversation
@kubealex I'm leaving this in draft state atm, but I'd love if you could do a brief review to make sure you like the direction and to get your overall feedback. |
- name: k8s-jackett | ||
version: ^0.9.0 | ||
repository: "file://./jackett" | ||
condition: jackett.enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enabled
flags move out of values and into the deps section.
### CONFIGMAPS | ||
## INIT-CONTAINER | ||
apiVersion: v1 | ||
data: | ||
ServerConfig.json: | | ||
{ | ||
"BasePathOverride": "{{ .Values.jackett.ingress.path }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each chart being self contained means qualified paths like this one don't need the .jackett.
portion anymore.
@@ -1,12 +1,10 @@ | |||
{{ if .Values.jackett.enabled }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get this for free from the superchart structure.
@@ -25,8 +23,8 @@ kind: ConfigMap | |||
metadata: | |||
name: jackett-config | |||
data: | |||
PGID: "{{ .Values.general.pgid }}" | |||
PUID: "{{ .Values.general.puid }}" | |||
PGID: "{{ .Values.global.pgid }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global
is a helm special keyword here, and it achieves what general used to in the old structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably would be good to unify this file instead of copying it so many times. I'll try to look into that soon.
Jellyfin has been merged @reedjosh, can you double check if this in any way creates any clash? |
I will begin cleanup on this branch. Hopefully I'll have a non-draft PR within the next week. : ) |
@reedjosh Any idea how much cleanup you still want to do? Anywhere I can assist? |
@NigelVanHattum I'll try to get back to this sometime soon. Unfortunately, it will need quite a bit still as the upstream changes will need incorporating and my PR was still not polished even before that. I do still want this done though, so I'll try to get to it in the next week or so. |
Breaks the helm charts out into individual charts with a superchart pattern.
generally by pulling this branch down it can be used in the same manner it always was via:
When changes are made to the sub charts the changes can be pulled in via:
and in the future we can add a GitHub pages helm index for the charts and reference them via that.