Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kubearmor): refactor watchpolicies to use informers #1032

Merged

Conversation

achrefbensaad
Copy link
Member

@achrefbensaad achrefbensaad commented Jan 3, 2023

Purpose of PR?:

KubeArmor is loosing ksp events, this leads to having random failures in the CI.
This PR deprecated the use of resource watcher in favor of informers.

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@achrefbensaad achrefbensaad self-assigned this Jan 3, 2023
@achrefbensaad achrefbensaad force-pushed the refactore-watchpolicies-informer branch from c41f13f to 04f49c3 Compare January 3, 2023 07:11
Signed-off-by: Achref ben saad <achref@accuknox.com>
@achrefbensaad achrefbensaad force-pushed the refactore-watchpolicies-informer branch from 04f49c3 to 2021079 Compare January 3, 2023 07:55
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants